Add workspace support for full scans#1095
Closed
lelia wants to merge 4921 commits into
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--workspacesupport tosocket scan createso scans can be associated with the correct Socket workspace (API workspace query param onCreateOrgFullScan). Also allows persisting a default workspace viasocket scan setup.Changes
socket scan create --workspace <string>(optional)socket scan setupcan persistdefaults.scan.create.workspacein.socket/socket.jsonworkspacethroughhandleCreateNewScan→fetchCreateOrgFullScan→ SDKcreateFullScan(..., { workspace })pnpm run checkpasses locallypnpm-lock.yamlto resolve an outdated-lockfile mismatch during typecheckTesting
Added a unit test ensuring workspace is passed through:
packages/cli/test/unit/commands/scan/fetch-create-org-full-scan.test.mtsrefs: SocketDev/socket-python-cli#164 + SocketDev/socket-sdk-python#68
Note
Medium Risk
Adds a new
workspaceparameter that flows into the full-scan creation API request, which can change how scans are associated server-side. Also adjusts VFS tool extraction typing/tool lists and lockfile entries, which could affect SEA extraction behavior if assumptions about bundled tools are wrong.Overview
Adds
--workspacesupport tosocket scan create, including reading a default from.socket/socket.jsonand passing it throughhandleCreateNewScan→fetchCreateOrgFullScan→ SDKcreateFullScanas an optional API parameter.Extends
socket scan setupto prompt for and persistdefaults.scan.create.workspace(defaulting to the git repo owner when available), and updates debug output to include the workspace prefix.Fixes TypeScript issues in VFS extraction utilities (notably safer typing/validation in
basics/vfs-extractand expandingdlx/vfs-extract’sEXTERNAL_TOOLSlist), adds a unit test covering workspace passthrough, and updatespnpm-lock.yamlto resolve lockfile/specifier mismatches.Written by Cursor Bugbot for commit ed95813. This will update automatically on new commits. Configure here.